Dmp 5271 add api validation get transcriptions document #3093
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en — apply input validation (High) Added input validation to get transcription document as well as ensuring response codes are single quoted
…en — apply input validation (High) Added input validation to get transcription document as well as ensuring response codes are single quoted
karen-hedges
requested review from
DavidTMann,
cakeben and
jackmaloney
and removed request for
a team
hmcts-jenkins-cnp
bot
added
ns:darts-modernisation
prd:darts
rel:darts-api-pr-3093
labels
…en — apply input validation (High) Added input validation to get transcription document as well as ensuring response codes are single quoted
…en — apply input validation (High) Added input validation to get transcription document as well as ensuring response codes are single quoted
…scriptionsDocument' into DMP-5271-AddApiValidationGetTranscriptionsDocument
karen-hedges
commented
Oct 15, 2025
| ).build(); | ||
|
|
||
| @Test | ||
| void negativeTranscriptionId() { |
There was a problem hiding this comment.
Can you add to the method name the name of the method for controllers get transcription document which I think is attachTranscript
There was a problem hiding this comment.
This test will not reach the controller but I have updated the naming to be clearer
…scriptionsDocument' into DMP-5271-AddApiValidationGetTranscriptionsDocument
…scriptionsDocument' into DMP-5271-AddApiValidationGetTranscriptionsDocument
karen-hedges
commented
Oct 23, 2025
...k/gov/hmcts/darts/transcriptions/controller/TranscriptionControllerGetTranscriptionTest.java
Show resolved
Hide resolved
karen-hedges
commented
Oct 23, 2025
...nscriptions/controller/TranscriptionControllerUpdateTranscriptionWithTranscriberIntTest.java
Show resolved
Hide resolved
karen-hedges
commented
Oct 23, 2025
| - "Too many results" | ||
| - "Transcription document marked for deletion reason not found" | ||
| - "Failed to upload transcript" | ||
| - "Invalid transcription id" |
There was a problem hiding this comment.
is there an extra whitespace here?
…scriptionsDocument' into DMP-5271-AddApiValidationGetTranscriptionsDocument
DavidTMann
approved these changes
Oct 30, 2025
…en — apply input validation (High) Added input validation to get transcription document as well as ensuring response codes are single quoted
…en — apply input validation (High) Added input validation to get transcription document as well as ensuring response codes are single quoted
…en — apply input validation (High) Added input validation to get transcription document as well as ensuring response codes are single quoted
…en — apply input validation (High) Added input validation to get transcription document as well as ensuring response codes are single quoted
Itneet
force-pushed
the
DMP-5271-AddApiValidationGetTranscriptionsDocument
branch
from
3cdf6b3 to
8c408b7
Compare
…scriptionsDocument' into DMP-5271-AddApiValidationGetTranscriptionsDocument
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/DMP-5271
Change description
Added input validation to get transcription document as well as ensuring response codes are single quote
Authorisation.implto handle negative transcription IDs by throwing a BadRequestException.swagger-request-validator-corelibrary and tests inTranscriptionOpenApiContractTestto confirm that minimum and maximum values checking is applied. Note this only validatestranscriptions.yamland not the response returned by the application. Further integration tests were added inTranscriptionControllerDownloadTranscriptIntTestto confirm that the actual response for a negative transcription ID is a 400. The application already handles requests with a transcription ID that is higher than the maximum allowed value with a 400 response.Does this PR introduce a breaking change? (check one with "x")